Re: [PATCH v3 10/13] scsi: fnic: Add support for multiqueue (MQ) in fnic_main.c

From: John Garry
Date: Thu Nov 16 2023 - 12:33:20 EST


On 16/11/2023 16:32, John Garry wrote:

If you check blk_mq_update_queue_map(), for set->ops->map_queues unset we call blk_mq_map_queues() - I am just wondering what does the equivalent to blk_mq_map_queues() for you in these other modes.

I am concerned that it is not proper that we have a set->ops->map_queues method, but it does nothing in some scenarios.

I think we get away with this as mq_map[for all CPUs] is 0, which points to the only HW queue.

Thanks,
John