Re: [PATCH v5 2/2] mtd: spi-nor: Stop reporting warning message when soft reset is not suported

From: Pratyush Yadav
Date: Mon Nov 13 2023 - 07:44:48 EST


Hi Michael,

On Thu, Nov 09 2023, Michael Walle wrote:

>> From: "Chia-Lin Kao (AceLan)" <acelan.kao@xxxxxxxxxxxxx>
>> When the software reset command isn't supported, we now stop reporting
>> the warning message to avoid unnecessary warnings and potential confusion.
>> Reviewed-by: Dhruva Gole <d-gole@xxxxxx>
>> Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@xxxxxxxxxxxxx>
>
> Reviewed-by: Michael Walle <michael@xxxxxxxx>

I did read your reply on the previous thread but did not find time to
write a response. I do largely see sense in your argument though I have
not fully thought it through yet. But I think it would be great if we
can ask the controller "do we need to do a soft reset?"

Anyway, I do not think this patch does anything too bad so it is
probably not worth debating so much on. So for now,

Acked-by: Pratyush Yadav <pratyush@xxxxxxxxxx>

--
Regards,
Pratyush Yadav