Re: [PATCH v5 2/2] mtd: spi-nor: Stop reporting warning message when soft reset is not suported

From: Mika Westerberg
Date: Fri Nov 10 2023 - 13:29:15 EST


On Wed, Nov 08, 2023 at 05:43:03PM +0800, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@xxxxxxxxxxxxx>
>
> When the software reset command isn't supported, we now stop reporting
> the warning message to avoid unnecessary warnings and potential confusion.
>
> Reviewed-by: Dhruva Gole <d-gole@xxxxxx>
> Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@xxxxxxxxxxxxx>

Looks good to me, only small comment is that perhaps you want to update
the kernel-doc of spi_mem_exec_op() to mention that if the
driver/controller does not support reset it can return -EOPNOTSUPP.

In any case,

Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>