Re: [PATCH] dt-bindings: ufs: Add msi-parent for UFS MCQ

From: Rob Herring
Date: Thu Nov 09 2023 - 08:55:32 EST


On Mon, Nov 6, 2023 at 11:56 AM Bart Van Assche <bvanassche@xxxxxxx> wrote:
>
> On 11/6/23 06:48, Rob Herring wrote:
> > On Wed, Nov 01, 2023 at 06:48:13PM +0800, Ziqi Chen wrote:
> >> The Message Signaled Interrupts (MSI) has been introduced
> >> to UFS driver since the MCQ be enabled.
> >
> > Not really relevant when a driver supported MSI, but the when the h/w
> > did. Has UFS always supported MSI? It was added in some version of the
> > spec?
>
> MSI support has been introduced in UFSHCI version 4.0 and I think that
> the controller vendor can decide whether or not to implement MSI. Does
> this mean that the patch needs to be improved?

Yes, this information is what should be in the commit msg rather than
driver details.

Rob