Re: [PATCH] dt-bindings: ufs: Add msi-parent for UFS MCQ

[Ziqi Chen]

On 11/7/2023 1:56 AM, Bart Van Assche wrote:
> On 11/6/23 06:48, Rob Herring wrote:
> > On Wed, Nov 01, 2023 at 06:48:13PM +0800, Ziqi Chen wrote:
> > > The Message Signaled Interrupts (MSI) has been introduced
> > > to UFS driver since the MCQ be enabled.
> >
> > Not really relevant when a driver supported MSI, but the when the h/w
> > did. Has UFS always supported MSI? It was added in some version of the
> > spec?
>
> MSI support has been introduced in UFSHCI version 4.0 and I think that
> the controller vendor can decide whether or not to implement MSI. Does
> this mean that the patch needs to be improved?
>
> Thanks,
>
> Bart.

Hi Rob, in my previous patch " dt-bindings: ufs: qcom: Add msi-parent 
for UFS MCQ",  Manivannan Sadhasivam also think instead of 
qcom,ufs.yaml, this should be part of ufs-common.yaml.

please let me know if there is any others I need to improve for this 
patch. Thanks a lot.


Best Regards,
Ziqi