Re: [PATCH v3 3/6] media: qcom: camss: csiphy-3ph: Add Gen2 v1.1 two-phase MIPI CSI-2 DPHY init

[Bryan O'Donoghue]

On 07/11/2023 21:43, Konrad Dybcio wrote:
> On 11/5/23 18:45, Bryan O'Donoghue wrote:
> > Add a PHY configuration sequence for the sc8280xp which uses a Qualcomm
> > Gen 2 version 1.1 CSI-2 PHY.
> >
> > The PHY can be configured as two phase or three phase in C-PHY or D-PHY
> > mode. This configuration supports two-phase D-PHY mode.
> >
> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> > ---
> Makes it sound like the current 2ph/3ph split is rather nonsensical?
>
> Perhaps we should restructure it to match hw revision? Especially since
> one can get it from the hardware itself..
>
> Konrad

For the C-PHY though we have to either add or remove caps - I forget 
which on ~ all of our reference platforms.

"The PHY can do it" but I'd be surprised to find there's a single real 
implementation of it outside of a silicon test bench.

---
bod