Re: [PATCH] net: phy: at803x: add QCA8084 ethernet phy support

[Jie Luo]

On 11/3/2023 9:01 PM, Andrew Lunn wrote:
> >   #define QCA8081_PHY_ID				0x004dd101
> > +#define QCA8081_PHY_MASK			0xffffff00
>
> That is an unusual mask. Please check it is correct. All you should
> need its PHY_ID_MATCH_EXACT, PHY_ID_MATCH_MODEL, PHY_ID_MATCH_VENDOR.

Thanks Andrew for the review.
The PHY ID of qca8084 is correct, i will update to use 
PHY_ID_MATCH_EXACT in the new added entry for qca8084.

> > @@ -1767,6 +1781,20 @@ static int qca808x_config_init(struct phy_device *phydev)
> >   {
> >   	int ret;
> >   
> > +	if (phydev->phy_id == QCA8084_PHY_ID) {
> > +		/* Invert ADC clock edge */
> > +		ret = at803x_debug_reg_mask(phydev, QCA8084_ADC_CLK_SEL,
> > +					    QCA8084_ADC_CLK_SEL_ACLK,
> > +					    FIELD_PREP(QCA8084_ADC_CLK_SEL_ACLK,
> > +						       QCA8084_ADC_CLK_SEL_ACLK_FALL));
> > +		if (ret < 0)
> > +			return ret;
> > +
> > +		/* Adjust MSE threshold value to avoid link issue with some link partner */
> > +		return phy_write_mmd(phydev, MDIO_MMD_PMAPMD,
> > +				QCA8084_MSE_THRESHOLD, QCA8084_MSE_THRESHOLD_2P5G_VAL);
> > +	}
> > +
>
> Please add a qca8084_config_init() and use that from the phy_driver
> structure.

OK.

> >   	/* Active adc&vga on 802.3az for the link 1000M and 100M */
> >   	ret = phy_modify_mmd(phydev, MDIO_MMD_PCS, QCA808X_PHY_MMD3_ADDR_CLD_CTRL7,
> >   			QCA808X_8023AZ_AFE_CTRL_MASK, QCA808X_8023AZ_AFE_EN);
> > @@ -1958,6 +1986,11 @@ static int qca808x_cable_test_start(struct phy_device *phydev)
> >   	phy_write_mmd(phydev, MDIO_MMD_PCS, 0x807a, 0xc060);
> >   	phy_write_mmd(phydev, MDIO_MMD_PCS, 0x807e, 0xb060);
> >   
> > +	if (phydev->phy_id == QCA8084_PHY_ID) {
> > +		phy_write_mmd(phydev, MDIO_MMD_PCS, 0x8075, 0xa060);
> > +		phy_write_mmd(phydev, MDIO_MMD_PCS, 0x807f, 0x1eb0);
> > +	}
> > +
>
> Please add a comment what this is doing.

Ok, will add comments in the next patch.

> >   }, {
> >   	/* Qualcomm QCA8081 */
> > -	PHY_ID_MATCH_EXACT(QCA8081_PHY_ID),
> > -	.name			= "Qualcomm QCA8081",
> > +	.phy_id			= QCA8081_PHY_ID,
> > +	.phy_id_mask		= QCA8081_PHY_MASK,
> > +	.name			= "Qualcomm QCA808X",
>
> Please add a new entry for the 8084.
>
>         Andrew

Will add it in the next patch, thanks.