Re: [PATCH net-next V4] ptp: fix corrupted list in ptp_open
From: kernel test robot
Date: Sat Nov 04 2023 - 02:47:39 EST
Hi Edward,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Edward-Adam-Davis/ptp-fix-corrupted-list-in-ptp_open/20231104-112916
base: net-next/main
patch link: https://lore.kernel.org/r/tencent_8A38BBB333189E6E1B4A4B821BF82569BA08%40qq.com
patch subject: [PATCH net-next V4] ptp: fix corrupted list in ptp_open
config: arc-randconfig-001-20231104 (https://download.01.org/0day-ci/archive/20231104/202311041344.zDyYh5Ty-lkp@xxxxxxxxx/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231104/202311041344.zDyYh5Ty-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311041344.zDyYh5Ty-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/ptp/ptp_chardev.c: In function 'ptp_release':
>> drivers/ptp/ptp_chardev.c:148:23: warning: unused variable 'flags' [-Wunused-variable]
148 | unsigned long flags;
| ^~~~~
vim +/flags +148 drivers/ptp/ptp_chardev.c
8f5de6fb245326 Xabier Marquiegui 2023-10-12 142
8f5de6fb245326 Xabier Marquiegui 2023-10-12 143 int ptp_release(struct posix_clock_context *pccontext)
8f5de6fb245326 Xabier Marquiegui 2023-10-12 144 {
8f5de6fb245326 Xabier Marquiegui 2023-10-12 145 struct timestamp_event_queue *queue = pccontext->private_clkdata;
f0e5eaa3097d80 Edward Adam Davis 2023-11-04 146 struct ptp_clock *ptp =
f0e5eaa3097d80 Edward Adam Davis 2023-11-04 147 container_of(pccontext->clk, struct ptp_clock, clock);
8f5de6fb245326 Xabier Marquiegui 2023-10-12 @148 unsigned long flags;
8f5de6fb245326 Xabier Marquiegui 2023-10-12 149
8f5de6fb245326 Xabier Marquiegui 2023-10-12 150 if (queue) {
f0e5eaa3097d80 Edward Adam Davis 2023-11-04 151 mutex_lock(&ptp->tsevq_mux);
403376ddb4221b Xabier Marquiegui 2023-10-12 152 debugfs_remove(queue->debugfs_instance);
8f5de6fb245326 Xabier Marquiegui 2023-10-12 153 pccontext->private_clkdata = NULL;
8f5de6fb245326 Xabier Marquiegui 2023-10-12 154 list_del(&queue->qlist);
f0e5eaa3097d80 Edward Adam Davis 2023-11-04 155 mutex_unlock(&ptp->tsevq_mux);
c5a445b1e9347b Xabier Marquiegui 2023-10-12 156 bitmap_free(queue->mask);
8f5de6fb245326 Xabier Marquiegui 2023-10-12 157 kfree(queue);
8f5de6fb245326 Xabier Marquiegui 2023-10-12 158 }
d94ba80ebbea17 Richard Cochran 2011-04-22 159 return 0;
d94ba80ebbea17 Richard Cochran 2011-04-22 160 }
d94ba80ebbea17 Richard Cochran 2011-04-22 161
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki