Re: [PATCH v11 3/4] clk: qcom: common: commonize qcom_cc_really_probe

From: kernel test robot
Date: Fri Nov 03 2023 - 18:26:25 EST


Hi Luo,

kernel test robot noticed the following build errors:

[auto build test ERROR on ff269e2cd5adce4ae14f883fc9c8803bc43ee1e9]

url: https://github.com/intel-lab-lkp/linux/commits/Luo-Jie/clk-qcom-branch-Add-clk_branch2_prepare_ops/20231103-185251
base: ff269e2cd5adce4ae14f883fc9c8803bc43ee1e9
patch link: https://lore.kernel.org/r/20231103104846.30875-4-quic_luoj%40quicinc.com
patch subject: [PATCH v11 3/4] clk: qcom: common: commonize qcom_cc_really_probe
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231104/202311040623.9oyUHQ6A-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231104/202311040623.9oyUHQ6A-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311040623.9oyUHQ6A-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

drivers/clk/qcom/camcc-sm8550.c: In function 'cam_cc_sm8550_probe':
>> drivers/clk/qcom/camcc-sm8550.c:3547:36: error: passing argument 1 of 'qcom_cc_really_probe' from incompatible pointer type [-Werror=incompatible-pointer-types]
3547 | ret = qcom_cc_really_probe(pdev, &cam_cc_sm8550_desc, regmap);
| ^~~~
| |
| struct platform_device *
In file included from drivers/clk/qcom/camcc-sm8550.c:19:
drivers/clk/qcom/common.h:61:48: note: expected 'struct device *' but argument is of type 'struct platform_device *'
61 | extern int qcom_cc_really_probe(struct device *dev,
| ~~~~~~~~~~~~~~~^~~
cc1: some warnings being treated as errors


vim +/qcom_cc_really_probe +3547 drivers/clk/qcom/camcc-sm8550.c

ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3505
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3506 static int cam_cc_sm8550_probe(struct platform_device *pdev)
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3507 {
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3508 struct regmap *regmap;
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3509 int ret;
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3510
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3511 ret = devm_pm_runtime_enable(&pdev->dev);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3512 if (ret)
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3513 return ret;
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3514
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3515 ret = pm_runtime_resume_and_get(&pdev->dev);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3516 if (ret)
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3517 return ret;
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3518
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3519 regmap = qcom_cc_map(pdev, &cam_cc_sm8550_desc);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3520 if (IS_ERR(regmap)) {
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3521 pm_runtime_put(&pdev->dev);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3522 return PTR_ERR(regmap);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3523 }
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3524
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3525 clk_lucid_ole_pll_configure(&cam_cc_pll0, regmap, &cam_cc_pll0_config);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3526 clk_lucid_ole_pll_configure(&cam_cc_pll1, regmap, &cam_cc_pll1_config);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3527 clk_rivian_evo_pll_configure(&cam_cc_pll2, regmap, &cam_cc_pll2_config);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3528 clk_lucid_ole_pll_configure(&cam_cc_pll3, regmap, &cam_cc_pll3_config);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3529 clk_lucid_ole_pll_configure(&cam_cc_pll4, regmap, &cam_cc_pll4_config);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3530 clk_lucid_ole_pll_configure(&cam_cc_pll5, regmap, &cam_cc_pll5_config);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3531 clk_lucid_ole_pll_configure(&cam_cc_pll6, regmap, &cam_cc_pll6_config);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3532 clk_lucid_ole_pll_configure(&cam_cc_pll7, regmap, &cam_cc_pll7_config);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3533 clk_lucid_ole_pll_configure(&cam_cc_pll8, regmap, &cam_cc_pll8_config);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3534 clk_lucid_ole_pll_configure(&cam_cc_pll9, regmap, &cam_cc_pll9_config);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3535 clk_lucid_ole_pll_configure(&cam_cc_pll10, regmap, &cam_cc_pll10_config);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3536 clk_lucid_ole_pll_configure(&cam_cc_pll11, regmap, &cam_cc_pll11_config);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3537 clk_lucid_ole_pll_configure(&cam_cc_pll12, regmap, &cam_cc_pll12_config);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3538
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3539 /*
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3540 * Keep clocks always enabled:
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3541 * cam_cc_gdsc_clk
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3542 * cam_cc_sleep_clk
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3543 */
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3544 regmap_update_bits(regmap, 0x1419c, BIT(0), BIT(0));
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3545 regmap_update_bits(regmap, 0x142cc, BIT(0), BIT(0));
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3546
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 @3547 ret = qcom_cc_really_probe(pdev, &cam_cc_sm8550_desc, regmap);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3548
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3549 pm_runtime_put(&pdev->dev);
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3550
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3551 return ret;
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3552 }
ccc4e6a061a21d Jagadeesh Kona 2023-07-07 3553

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki