security/apparmor/task.c:290: warning: Function parameter or member 'tracee_cred' not described in 'aa_may_ptrace'

From: kernel test robot
Date: Fri Nov 03 2023 - 18:01:02 EST


Hi John,

FYI, the error/warning still remains.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: e392ea4d4d00880bf94550151b1ace4f88a4b17a
commit: 90c436a64a6e20482a9a613c47eb4af2e8a5328e apparmor: pass cred through to audit info.
date: 2 weeks ago
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20231104/202311040508.AUhi04RY-lkp@xxxxxxxxx/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231104/202311040508.AUhi04RY-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311040508.AUhi04RY-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

security/apparmor/task.c:290: warning: Function parameter or member 'tracer_cred' not described in 'aa_may_ptrace'
>> security/apparmor/task.c:290: warning: Function parameter or member 'tracee_cred' not described in 'aa_may_ptrace'


vim +290 security/apparmor/task.c

eac931254d99c5 John Johansen 2021-11-22 278
eac931254d99c5 John Johansen 2021-11-22 279 /**
eac931254d99c5 John Johansen 2021-11-22 280 * aa_may_ptrace - test if tracer task can trace the tracee
eac931254d99c5 John Johansen 2021-11-22 281 * @tracer: label of the task doing the tracing (NOT NULL)
eac931254d99c5 John Johansen 2021-11-22 282 * @tracee: task label to be traced
eac931254d99c5 John Johansen 2021-11-22 283 * @request: permission request
eac931254d99c5 John Johansen 2021-11-22 284 *
eac931254d99c5 John Johansen 2021-11-22 285 * Returns: %0 else error code if permission denied or error
eac931254d99c5 John Johansen 2021-11-22 286 */
90c436a64a6e20 John Johansen 2022-09-19 287 int aa_may_ptrace(const struct cred *tracer_cred, struct aa_label *tracer,
90c436a64a6e20 John Johansen 2022-09-19 288 const struct cred *tracee_cred, struct aa_label *tracee,
eac931254d99c5 John Johansen 2021-11-22 289 u32 request)
eac931254d99c5 John Johansen 2021-11-22 @290 {

:::::: The code at line 290 was first introduced by commit
:::::: eac931254d99c5aeb12ace02366dd338c4371164 apparmor: move ptrace mediation to more logical task.{h,c}

:::::: TO: John Johansen <john.johansen@xxxxxxxxxxxxx>
:::::: CC: John Johansen <john.johansen@xxxxxxxxxxxxx>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki