Re: Possible bug report: kernel 6.5.0/6.5.1 high load when CIFS share is mounted (cifsd-cfid-laundromat in"D" state)

From: Steve French
Date: Mon Oct 23 2023 - 22:51:44 EST


We probably want this one as well ...

commit 2da338ff752a2789470d733111a5241f30026675
Author: Steve French <stfrench@xxxxxxxxxxxxx>
Date: Tue Sep 19 11:35:53 2023 -0500

smb3: do not start laundromat thread when dir leases
disabled

When no directory lease support, or for IPC shares where directories
can not be opened, do not start an unneeded laundromat thread for
that mount (it wastes resources).

Fixes: d14de8067e3f ("cifs: Add a laundromat thread for cached directories")
Reviewed-by: Paulo Alcantara (SUSE) <pc@xxxxxxxxxxxxx>
Acked-by: Tom Talpey <tom@xxxxxxxxxx>
Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>



Any objections to adding that one to the list as well? The patches
all seem to apply fine to current 6.5-stable-rc

On Mon, Oct 23, 2023 at 9:07 AM Paulo Alcantara <pc@xxxxxxxxxxxxx> wrote:
>
> "Dr. Bernd Feige" <bernd.feige@xxxxxxxxxxxxxxxxxxxxx> writes:
>
> > I can confirm that the patches apply cleanly on 6.5.8 and help a lot
> > with the issue here (vers=3.1.1, gentoo client, MS AD server with DFS).
>
> Thanks for testing it.
>
> Steve, I would suggest below commits for v6.5.y
>
> 238b351d0935 ("smb3: allow controlling length of time directory entries are cached with dir leases")
> 6a50d71d0fff ("smb3: allow controlling maximum number of cached directories")
> 2da338ff752a ("smb3: do not start laundromat thread when dir leases disabled")
> e95f3f744650 ("smb: client: make laundromat a delayed worker")
> 81ba10959970 ("smb: client: prevent new fids from being removed by laundromat")
>
> If OK, please ask stable team to pick those up.



--
Thanks,

Steve