Re: [PATCH 04/11] iio: adc: Update bindings to remove support for ADC7 name used on QCOM PMICs

From: Jishnu Prakash
Date: Mon Oct 23 2023 - 02:11:53 EST


Hi Jonathan,

On 7/8/2023 8:32 PM, Jonathan Cameron wrote:
On Sat, 8 Jul 2023 12:58:28 +0530
Jishnu Prakash <quic_jprakash@xxxxxxxxxxx> wrote:

Now that usage of "ADC7" name has been replaced with usage of "ADC5
Gen2" name everywhere, remove all support for "ADC7" name.

Signed-off-by: Jishnu Prakash <quic_jprakash@xxxxxxxxxxx>

@@ -26,7 +26,6 @@ properties:
- qcom,spmi-vadc
- qcom,spmi-adc5
- qcom,spmi-adc-rev2
- - qcom,spmi-adc7
- qcom,spmi-adc5-gen2
reg:
@@ -214,9 +213,7 @@ allOf:
properties:
compatible:
contains:
- enum :
- - qcom,spmi-adc7
- - qcom,spmi-adc5-gen2
+ const: qcom,spmi-adc5-gen2
then:
patternProperties:
Hmm. Definitely can't drop support (as per comment on next patch).
I think you should just mark it deprecated rather than remove it here but maybe
you can drop it. Let's see what DT binding maintainers say.

Jonathan

Yes, I'll mark it deprecated without removing it.

Thanks,

Jishnu