Re: [PATCH 03/11] ARM: dts: qcom: Update devicetree for ADC7 rename for QCOM PMICs

From: Jishnu Prakash
Date: Mon Oct 23 2023 - 02:10:14 EST


Hi Krzysztof,

On 7/9/2023 10:48 PM, Krzysztof Kozlowski wrote:
On 08/07/2023 09:28, Jishnu Prakash wrote:
The name "ADC7" needs to be replaced with the name "ADC5_GEN2"
everywhere to match the convention used for these ADC peripherals
on Qualcomm Technologies, Inc. PMICs. Update devicetree files for
We do not rename compatibles to match convention. Please provide proper
rationale.

I'll avoid renaming the compatible directly, will just mark it deprecated - but is it fine to do the other changes, for updating the macro names used in devicetree (replacing the ADC7 macros with the ADC5 Gen2 macros)?

I do see an example of a macro change in devicetree done in this patch: https://lore.kernel.org/all/cover.1646388139.git.zong.li@xxxxxxxxxx/.

Patch 2 here replaced some macro definitions: https://lore.kernel.org/all/f9284873c2993a9952d9fe4f8dd5e89f20daab75.1646388139.git.zong.li@xxxxxxxxxx/.

Patch 3 made the corresponding update in devicetree files: https://lore.kernel.org/all/db92d209fa700f7da8bc8028083476fcc138d80e.1646388139.git.zong.li@xxxxxxxxxx/.

From this mail, it looks like the maintainer was willing to pick them at that time: https://lore.kernel.org/all/20220315225652.CDAD1C340E8@xxxxxxxxxxxxxxx/, would something similar be possible here?

Thanks,

Jishnu