Re: [PATCH v2] dt-bindings: serial: 8250_omap: add rs485-rts-active-high

[Francesco Dolcini]

Hello Geert,

On Thu, Oct 19, 2023 at 12:09:06PM +0200, Geert Uytterhoeven wrote:
> On Wed, May 31, 2023 at 1:14 PM Francesco Dolcini <francesco@xxxxxxxxxx> wrote:
> > From: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> >
> > Add rs485-rts-active-high property, this was removed by mistake.
> > In general we just use rs485-rts-active-low property, however the OMAP
> > UART for legacy reason uses the -high one.
> >
> > Fixes: 767d3467eb60 ("dt-bindings: serial: 8250_omap: drop rs485 properties")
> > Closes: https://lore.kernel.org/all/ZGefR4mTHHo1iQ7H@xxxxxxxxxxxxxxxxxxxxxxxxxxxx/
> > Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> > ---
> > v2: removed reported-by
> 
> Thanks for your patch, which is now commit 403e97d6ab2cb6fd
> ("dt-bindings: serial: 8250_omap: add rs485-rts-active-high")
> in v6.4-rc5.
> 
> > --- a/Documentation/devicetree/bindings/serial/8250_omap.yaml
> > +++ b/Documentation/devicetree/bindings/serial/8250_omap.yaml
> > @@ -70,6 +70,7 @@ properties:
> >    dsr-gpios: true
> >    rng-gpios: true
> >    dcd-gpios: true
> > +  rs485-rts-active-high: true
> 
> make dt_binding_check complains:
> 
>     Documentation/devicetree/bindings/serial/8250_omap.yaml:
> rs485-rts-active-high: missing type definition

For some reasons it works for me (and worked when I did send the patch)

$ make dt_binding_check DT_SCHEMA_FILES=8250_omap.yaml
...
  HOSTCC  scripts/dtc/libfdt/fdt_overlay.o
  HOSTCC  scripts/dtc/fdtoverlay.o
  HOSTLD  scripts/dtc/fdtoverlay
  LINT    Documentation/devicetree/bindings
invalid config: unknown option "required" for rule "quoted-strings"
xargs: /usr/bin/yamllint: exited with status 255; aborting
  CHKDT   Documentation/devicetree/bindings/processed-schema.json
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
/home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: ignoring, error in schema: properties: qcom,ls-fs-output-impedance-bp
/home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/arm/vexpress-sysreg.yaml: ignoring, error in schema: properties: gpio-controller
/home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: ignoring, error in schema: patternProperties: ^thermistor@: properties: adi,excitation-current-nanoamp
/home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml: ignoring, error in schema: patternProperties: ^channel@([0-9a-f])$: properties: adi,burnout-current-nanoamp
/home/francesco/Toradex/sources/linux/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml: ignoring, error in schema: properties: adi,ext2-burnout-current-nanoamp
  DTEX    Documentation/devicetree/bindings/serial/8250_omap.example.dts
  DTC_CHK Documentation/devicetree/bindings/serial/8250_omap.example.dtb


any idea on what could be different between us?

> This property should have been added to
> Documentation/devicetree/bindings/serial/serial.yaml first.

Francesco