Re: [PATCH v2] dt-bindings: serial: 8250_omap: add rs485-rts-active-high

[Geert Uytterhoeven]

Hi Francesco,

On Wed, May 31, 2023 at 1:14 PM Francesco Dolcini <francesco@xxxxxxxxxx> wrote:
> From: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
>
> Add rs485-rts-active-high property, this was removed by mistake.
> In general we just use rs485-rts-active-low property, however the OMAP
> UART for legacy reason uses the -high one.
>
> Fixes: 767d3467eb60 ("dt-bindings: serial: 8250_omap: drop rs485 properties")
> Closes: https://lore.kernel.org/all/ZGefR4mTHHo1iQ7H@xxxxxxxxxxxxxxxxxxxxxxxxxxxx/
> Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> ---
> v2: removed reported-by

Thanks for your patch, which is now commit 403e97d6ab2cb6fd
("dt-bindings: serial: 8250_omap: add rs485-rts-active-high")
in v6.4-rc5.

> --- a/Documentation/devicetree/bindings/serial/8250_omap.yaml
> +++ b/Documentation/devicetree/bindings/serial/8250_omap.yaml
> @@ -70,6 +70,7 @@ properties:
>    dsr-gpios: true
>    rng-gpios: true
>    dcd-gpios: true
> +  rs485-rts-active-high: true

make dt_binding_check complains:

    Documentation/devicetree/bindings/serial/8250_omap.yaml:
rs485-rts-active-high: missing type definition

This property should have been added to
Documentation/devicetree/bindings/serial/serial.yaml first.

>    rts-gpio: true
>    power-domains: true
>    clock-frequency: true

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds