Re: [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule

From: Eric Dumazet
Date: Thu Oct 05 2023 - 12:34:10 EST


On Tue, Oct 3, 2023 at 8:36 PM Christian Marangi <ansuelsmth@xxxxxxxxx> wrote:
>
> Now that napi_schedule return a bool, we can drop napi_reschedule that
> does the same exact function. The function comes from a very old commit
> bfe13f54f502 ("ibm_emac: Convert to use napi_struct independent of struct
> net_device") and the purpose is actually deprecated in favour of
> different logic.
>
> Convert every user of napi_reschedule to napi_schedule.
>
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> Acked-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> # ath10k
> Acked-by: Nick Child <nnac123@xxxxxxxxxxxxx> # ibm
> Acked-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> # for can/dev/rx-offload.c

OK, but I suspect some users of napi_reschedule() might not be race-free...

Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>