Re: [PATCH kernel v2] x86/compressed/64: reduce #VC nesting for intercepted CPUID for SEV-SNP guest

From: Ingo Molnar
Date: Sun Oct 01 2023 - 08:18:11 EST



* Borislav Petkov <bp@xxxxxxxxx> wrote:

> On Sun, Oct 01, 2023 at 08:40:30PM +1100, Alexey Kardashevskiy wrote:
> > Ingo says different, who wins? :)
>
> I do: a function gives you type checking - a macro doesn't.

That's false, because this specific macro don't force any types, it
only passes types through as-is to type-checked functions, so both
the macro and the function variant does similar quality of type
checking ...

But I'm fine with both approaches, I suggested a macro because the
existing rdtsc definitions used macros already - but I have no
strong feelings which particular color this shed gets painted ...

Thanks,

Ingo