Re: [PATCH v3] mmc: Add quirk MMC_QUIRK_BROKEN_CACHE_FLUSH for Micron eMMC Q2J54A
From: Bean Huo
Date: Wed Sep 27 2023 - 04:56:59 EST
On Fri, 2023-09-22 at 19:01 +0200, Francesco Dolcini wrote:
> > +
> > + if (host->card->quirks &
> > MMC_QUIRK_BROKEN_CACHE_FLUSH &&
> > + !host->card->written_flag && !ret)
> > + host->card->written_flag = true;
>
> From what I can see this branch is followed for both REQ_OP_READ and
> REQ_OP_WRITE, and I would say we want to set this flag only for
> REQ_OP_WRITE.
>
> Am I wrong?
>
> Francesco
you are right, we only care about write, I will update it in the next
version, thanks for your review!
Kind regards,
Bean