Re: [PATCH 1/2] spi: renesas,rzv2m-csi: Add SPI Slave related properties

From: Mark Brown
Date: Wed Sep 27 2023 - 04:56:51 EST


On Tue, Sep 26, 2023 at 10:08:17PM +0100, Fabrizio Castro wrote:
> The CSI IP found inside the Renesas RZ/V2M SoC can also work
> in SPI slave mode.
> When working in slave mode, the IP can make use of the SS
> (Slave Select) pin, with "low" as default active level.
> The active level of SS can be changed to "high" upon configuration.
> This patch adds two new properties, one to make use of the
> SS pin when in slave mode, and one to make the SS pin active high.

Please avoid the use of outdated terminology like this, prefer "device
mode" or similar.

> + renesas,csi-ss:
> + type: boolean
> + description:
> + Use CSI Slave Selection (SS) pin to enable transmission and reception when
> + in slave mode.

When would this ever not be true when in device mode?

Attachment: signature.asc
Description: PGP signature