Re: [PATCH 11/13] arm64: dts: qcom: msm8916-samsung-gt5: Add sound and modem

[Konrad Dybcio]

On 26.09.2023 18:51, Stephan Gerhold wrote:
> From: Jasper Korten <jja2000@xxxxxxxxx>
> 
> Enable sound and modem for the Samsung Galaxy Tab A 2015 tablets.
> The setup is similar to most MSM8916 devices, i.e.:
> 
>  - QDSP6 audio
>  - Headphones/microphones via digital/analog codec in
>    MSM8916/PM8916. Earpiece exists on samsung-gt58 only.
>  - WWAN Internet via BAM-DMUX
> 
> except:
> 
>  - gt510: Stereo Maxim MAX98357A codecs for speaker on Quaternary MI2S
>  - gt58: Mono NXP TFA9895 codec for speaker on Quaternary MI2S
>    - For some reason connected to GPIOs where no hardware I2C
>      controller is available -> need to use i2c-gpio
> - Samsung-specific audio jack detection (not supported yet)
> 
> Signed-off-by: Jasper Korten <jja2000@xxxxxxxxx>
> Co-developed-by: Siddharth Manthan <siddharth.manthan@xxxxxxxxx>
> Signed-off-by: Siddharth Manthan <siddharth.manthan@xxxxxxxxx>
> Co-developed-by: Nikita Travkin <nikita@xxxxxxx>
> Signed-off-by: Nikita Travkin <nikita@xxxxxxx>
> [Stephan: Add consistent commit message]
> Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
> ---
>  .../boot/dts/qcom/msm8916-samsung-gt5-common.dtsi  | 36 ++++++++++++++++++
>  arch/arm64/boot/dts/qcom/msm8916-samsung-gt510.dts | 23 ++++++++++++
>  arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dts  | 43 ++++++++++++++++++++++
>  3 files changed, 102 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
> index 6a16eb5ce07b..396853fcece5 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
> @@ -3,9 +3,12 @@
>  /dts-v1/;
>  
>  #include "msm8916-pm8916.dtsi"
> +#include "msm8916-modem-qdsp6.dtsi"
> +
>  #include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/input/input.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/sound/apq8016-lpass.h>
>  
>  / {
>  	aliases {
> @@ -116,6 +119,17 @@ &blsp_uart2 {
>  	status = "okay";
>  };
>  
> +&lpass {
> +	dai-link@3 {
> +		reg = <MI2S_QUATERNARY>;
> +		qcom,playback-sd-lines = <1>;
> +	};
> +};
status = reserved?

[...]
>  
> +	i2c-amplifier {
> +		compatible = "i2c-gpio";
> +		sda-gpios = <&tlmm 55 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
> +		scl-gpios = <&tlmm 56 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
non-msm8916 files have a space around the OR operator, hm

Konrad