Re: Subject: [patch V3 08/30] x86/microcode/intel: Save the microcode only after a successful late-load

From: Qiuxu Zhuo
Date: Mon Sep 25 2023 - 11:30:19 EST


> ...
> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>
> There are situations where the late microcode is loaded into memory, but is
> not applied:
>
> 1) The rendevouz fails

s/rendevouz/rendezvous/

> 2) The microcode is rejected by the CPUs
>
> If any of this happens then the pointer which was updated at firmware load
> time is stale and subsequent CPU hotplug operations either fail to update
> or create inconsistent microcode state.
>
> Save the loaded microcode in a separate pointer from with the late load is
> attempted and when successful, update the hotplug pointer accordingly via a
> new micrcode_ops callback.

s/micrcode_ops/microcode_ops

>
> Remove the pointless fallback in the loader to a microcode pointer which is
> never populated.
> ...