Re: [PATCH V3 1/4] dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible

[Sricharan Ramabadhran]

On 9/23/2023 5:14 PM, Krzysztof Kozlowski wrote:
> On 22/09/2023 13:51, Sricharan R wrote:
> > From: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
> >
> > IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt.
>
> Then why do you allow two interrupts?
 infact there is only one interrupt. Will fix in the binding
 description.

> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
> > ---
> >   [v3] Added the tsens-ipq5018 as  new binding without rpm
> >
> >   Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> > index 27e9e16e6455..a02829deeb24 100644
> > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> > @@ -44,6 +44,10 @@ properties:
> >                 - qcom,qcs404-tsens
> >             - const: qcom,tsens-v1
> >   
> > +      - description: v1 of TSENS without rpm
> > +        enum:
> > +          - qcom,ipq5018-tsens
>
> You miss now description of interrupts, like the other variants have.

 ok, will add it.

Regards,
 Sricharan