Re: [PATCH net-next 7/7] net: stmmac: Make PTP reference clock references more clear

From: Richard Cochran
Date: Sun Aug 27 2023 - 22:17:10 EST


On Thu, Aug 24, 2023 at 01:32:58PM -0500, Andrew Halaney wrote:

> @@ -34,14 +34,14 @@ static void config_sub_second_increment(void __iomem *ioaddr,
> * increment to twice the number of nanoseconds of a clock cycle.
> * The calculation of the default_addend value by the caller will set it
> * to mid-range = 2^31 when the remainder of this division is zero,
> - * which will make the accumulator overflow once every 2 ptp_clock
> + * which will make the accumulator overflow once every 2 clk_ptp_rate
> * cycles, adding twice the number of nanoseconds of a clock cycle :
> - * 2 * NSEC_PER_SEC / ptp_clock.
> + * 2 * NSEC_PER_SEC / clk_ptp_rate.
> */

This part of the driver is complete garbage. But that isn't your fault.

Richard