Re: [PATCH v1 1/1] tools/nolibc: i386: Fix a stack misalign bug on _start

From: Ammar Faizi
Date: Sun Aug 27 2023 - 03:24:26 EST


On Sun, Aug 27, 2023 at 08:53:26AM +0200, Thomas Weißschuh wrote:
> Afaik references to commits in commit messages are supposed to follow
> the same format as in the Fixes: tag.

Copied.

> Thanks for the fix!
>
> In general:
>
> Acked-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>

I'll fix the reference format, append your acked by tag, and explain
more about the logic behind 'sub $12, %esp' in v2.

I'm currently traveling, will send the v2 revision on Monday morning
Jakarta time.

> Also a Link: tag for the Reported-by: would be nice.

I would have linked the discussion if the report were on the list.
Unfortunately, Nicholas reported it offlist.

--
Ammar Faizi