Re: [PATCH net-next v2] page_pool: split types and declarations from page_pool.h

[Alexander Lobakin]

From: Yunsheng Lin <linyunsheng@xxxxxxxxxx>
Date: Thu, 27 Jul 2023 19:47:23 +0800

> On 2023/7/26 23:47, Jakub Kicinski wrote:
>> On Wed, 26 Jul 2023 12:48:05 +0200 Alexander Lobakin wrote:
>>>> I prefer the more systematic approach of creating a separate types.h
>>>> file, so I don't have to keep chasing people or cleaning up the include
>>>> hell myself. I think it should be adopted more widely going forward,
>>>> it's not just about the page pool.  
>>>
>>> I have this patch reworked to introduce
>>> include/net/page_pool/{types,helpers}.h in my tree, maybe someone could
>>> take a quick look[0] and say if this works while I'm preparing the next
>>> version for sending? Not the most MLish way, I know :s
>>>
>>> [0]
>>> https://github.com/alobakin/linux/commit/19741ee072c32eb1d30033cd4fcb236d1c00bfbf
>>
>> LGTM!
> 
> Hi, Alexander
> It seems you have taken it and adjust it accordingly, do you mind sending
> the next version along with your patchset, so that there is less patch
> conflict for both of us:)

Sure, I'm planning to do that, just had some work burden. I'm sending
the next rev today if everything goes fine.

> 
>>
>> .
>>

Thanks,
Olek