Re: [PATCH v3] ACPI/IORT: Remove erroneous id_count check in iort_node_get_rmr_info()

From: Catalin Marinas
Date: Thu Jul 27 2023 - 09:59:12 EST


On Thu, Jul 27, 2023 at 03:39:27PM +0200, Lorenzo Pieralisi wrote:
> On Mon, Jul 17, 2023 at 07:33:45PM +0800, Guanghui Feng wrote:
> > According to the ARM IORT specifications DEN 0049 issue E,
> > the "Number of IDs" field in the ID mapping format reports
> > the number of IDs in the mapping range minus one.
> >
> > In iort_node_get_rmr_info(), we erroneously skip ID mappings
> > whose "Number of IDs" equal to 0, resulting in valid mapping
> > nodes with a single ID to map being skipped, which is wrong.
> >
> > Fix iort_node_get_rmr_info() by removing the bogus id_count
> > check.
> >
> > Fixes: 491cf4a6735a ("ACPI/IORT: Add support to retrieve IORT RMR reserved regions")
> > Signed-off-by: Guanghui Feng <guanghuifeng@xxxxxxxxxxxxxxxxx>
> > ---
> > drivers/acpi/arm64/iort.c | 3 ---
> > 1 file changed, 3 deletions(-)
>
> Acked-by: Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>
>
> Catalin/Will,
>
> can you pick this up please ?

Would you like it merged in 6.5 or 6.6 is fine?

Thanks.

--
Catalin