Re: [PATCH] gpio: msc313: remove unnecessary call to platform_set_drvdata()

From: Andy Shevchenko
Date: Tue Jul 25 2023 - 09:19:42 EST


On Fri, Jul 21, 2023 at 07:14:31PM +0300, Andy Shevchenko wrote:
> On Fri, Jul 21, 2023 at 04:11:57PM +0300, Andrei Coardos wrote:
> > This function call was found to be unnecessary as there is no equivalent
> > platform_get_drvdata() call to access the private data of the driver.

Not true.

> > Also, the private data is defined in this driver, so there is no risk of
> > it being accessed outside of this driver file.
>
> Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>

I have to withdraw this, the patch is wrong.
NAK.

Sorry for the confusion (I have looked for the wrong pattern).

--
With Best Regards,
Andy Shevchenko