Re: [PATCH net-next v3] net: dsa: mv88e6xxx: Add erratum 3.14 for 88E6390X and 88E6190X

From: Ante Knezic
Date: Tue Jul 25 2023 - 05:59:46 EST


On Tue, 25 Jul 2023 10:56:25 +0200 Paolo Abeni wrote
> It looks like you are ignoring the errors reported by
> mv88e6390_erratum_3_14(). Should the above be:
>
> return mv88e6390_erratum_3_14(mpcs);
>
> instead?
>

I guess you are right. Would it make sense to do the evaluation for the
mv88e639x_sgmii_pcs_control_pwr(mpcs, true);
above as well?