Re: [PATCH 2/2] Input: lm8323 - convert to use devm_* api

[Christophe JAILLET]

Le 24/07/2023 à 21:01, Dmitry Torokhov a écrit :
> On Mon, Jul 24, 2023 at 08:53:11PM +0200, Christophe JAILLET wrote:
> > Le 24/07/2023 à 07:29, Dmitry Torokhov a écrit :
> > > From: Yangtao Li <frank.li@xxxxxxxx>
> > > +
> > > +		err = devm_led_classdev_register(dev, &pwm->cdev);
>
>                        ^^^^^^^^^^^^^^

Oops,
For some reason, I missed this hunk :(.

> > > -
> > > -	for (i = 0; i < 3; i++)
> > > -		if (lm->pwm[i].enabled)
> > > -			led_classdev_unregister(&lm->pwm[i].cdev);
> >
> > this look wrong.
>
> Why? It will be cleared up by devm.
>
> Thanks.

Sorry for the noise.

I've been puzzled by [1].

CJ

[1]: https://lore.kernel.org/all/20230714080611.81302-8-frank.li@xxxxxxxx/