Re: [PATCH 2/2] Input: lm8323 - convert to use devm_* api

From: Dmitry Torokhov
Date: Mon Jul 24 2023 - 15:01:33 EST


On Mon, Jul 24, 2023 at 08:53:11PM +0200, Christophe JAILLET wrote:
> Le 24/07/2023 à 07:29, Dmitry Torokhov a écrit :
> > From: Yangtao Li <frank.li@xxxxxxxx>
> > +
> > + err = devm_led_classdev_register(dev, &pwm->cdev);

^^^^^^^^^^^^^^

...

> > -
> > - for (i = 0; i < 3; i++)
> > - if (lm->pwm[i].enabled)
> > - led_classdev_unregister(&lm->pwm[i].cdev);
>
> this look wrong.

Why? It will be cleared up by devm.

Thanks.

--
Dmitry