Re: [patch 47/58] x86/apic: Remove pointless arguments from [native_]eoi_write()

From: Wei Liu
Date: Sun Jul 23 2023 - 18:45:40 EST


On Tue, Jul 18, 2023 at 01:15:47AM +0200, Thomas Gleixner wrote:
> Every callsite hands in the same constants which is a pointless exercise
> and cannot be optimized by the compiler due to the indirect calls.
>
> Use the constants in the eoi() callbacks and remove the arguments.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
> arch/x86/hyperv/hv_apic.c | 6 +++---

The change looks trivially correct.

In conjunction with the function name change:

Reviewed-by: Wei Liu <wei.liu@xxxxxxxxxx>