Re: [PATCH 1/8] drm/ssd130x: Fix pitch calculation in ssd130x_fb_blit_rect()

From: Javier Martinez Canillas
Date: Fri Jul 21 2023 - 18:40:29 EST


Javier Martinez Canillas <javierm@xxxxxxxxxx> writes:

Hello Geert,

> Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> writes:
>

[...]

>>
>> My point is that the 8 as used here is related to the number of bits per pixel,
>> not to the page height. The page height might also be impacted by the
>> number of bits per pixel, but that is orthogonal.
>>
>
> Ah, I see what you mean. Yes, you are right. We can later add a
> different variable when adding support for controllers using R4.
>
> Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
>

Pushed to drm-misc (drm-misc-next) since this fix is independent of the
rest of the patches. Thanks!

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat