Re: [PATCH v2 4/5] arm64: dts: qcom: ipq5332: Add thermal zone nodes

[Dmitry Baryshkov]

On 12/07/2023 15:50, Praveenkumar I wrote:
> On 7/12/2023 5:55 PM, Dmitry Baryshkov wrote:
> > On 12/07/2023 14:35, Praveenkumar I wrote:
> > > This patch adds thermal zone nodes for sensors present in
> > > IPQ5332.
> > >
> > > Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> > > ---
> > > [v2]:
> > >     Added passive trips and alignment change.
> > >
> > >   arch/arm64/boot/dts/qcom/ipq5332.dtsi | 78 +++++++++++++++++++++++++++
> > >   1 file changed, 78 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi 
> > > b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > > index 0eef77e36609..a1f59af97ee8 100644
> > > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > > @@ -480,4 +480,82 @@ timer {
> > >                    <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(4) | 
> > > IRQ_TYPE_LEVEL_LOW)>,
> > >                    <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(4) | 
> > > IRQ_TYPE_LEVEL_LOW)>;
> > >       };
> > > +
> > > +    thermal-zones {
> > > +        rfa-0-thermal {
> > > +            polling-delay-passive = <0>;
> > > +            polling-delay = <0>;
> > > +            thermal-sensors = <&tsens 11>;
> > > +
> > > +            trips {
> > > +                rfa-0-critical {
> > > +                    temperature = <125000>;
> > > +                    hysteresis = <1000>;
> > > +                    type = "critical";
> > > +                };
> > > +            };
> > > +        };
> > > +
> > > +        rfa-1-thermal {
> > > +            polling-delay-passive = <0>;
> > > +            polling-delay = <0>;
> > > +            thermal-sensors = <&tsens 12>;
> > > +
> > > +            trips {
> > > +                rfa-1-critical {
> > > +                    temperature = <125000>;
> > > +                    hysteresis = <1000>;
> > > +                    type = "critical";
> > > +                };
> > > +            };
> > > +        };
> > > +
> > > +        misc-thermal {
> > > +            polling-delay-passive = <0>;
> > > +            polling-delay = <0>;
> > > +            thermal-sensors = <&tsens 13>;
> > > +
> > > +            trips {
> > > +                misc-critical {
> > > +                    temperature = <125000>;
> > > +                    hysteresis = <1000>;
> > > +                    type = "critical";
> > > +                };
> > > +            };
> > > +        };
> > > +
> > > +        cpu-top-thermal {
> > > +            polling-delay-passive = <0>;
> > > +            polling-delay = <0>;
> > > +            thermal-sensors = <&tsens 14>;
> > > +
> > > +            trips {
> > > +                cpu-top-critical {
> > > +                    temperature = <115000>;
> > > +                    hysteresis = <1000>;
> > > +                    type = "critical";
> > > +                };
> > > +
> > > +                cpu-passive {
> > > +                    temperature = <105000>;
> > > +                    hysteresis = <1000>;
> > > +                    type = "passive";
> >
> > cooling device for this trip point?
>
> CPU Frequency scaling support is not yet added for IPQ5332. Planning to 
> add the cooling device after that in next set of patches.

Ack, thanks.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

> - Praveenkumar
>
> > > +                };
> > > +            };
> > > +        };
> > > +
> > > +        top-glue-thermal {
> > > +            polling-delay-passive = <0>;
> > > +            polling-delay = <0>;
> > > +            thermal-sensors = <&tsens 15>;
> > > +
> > > +            trips {
> > > +                top-glue-critical {
> > > +                    temperature = <125000>;
> > > +                    hysteresis = <1000>;
> > > +                    type = "critical";
> > > +                };
> > > +            };
> > > +        };
> > > +    };
> > >   };

--
With best wishes
Dmitry