Re: [PATCH v2 3/5] arm64: dts: qcom: ipq5332: Add tsens node

[Dmitry Baryshkov]

On 12/07/2023 15:48, Praveenkumar I wrote:
> On 7/12/2023 5:54 PM, Dmitry Baryshkov wrote:
> > On 12/07/2023 14:35, Praveenkumar I wrote:
> > > IPQ5332 has tsens v2.3.3 peripheral. This patch adds the tsense
> > > node with nvmem cells for calibration data.
> > >
> > > Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> > > ---
> > > [v2]:
> > >     Included qfprom nodes only for available sensors and removed
> > >     the offset suffix.
> > >
> > >   arch/arm64/boot/dts/qcom/ipq5332.dtsi | 66 +++++++++++++++++++++++++++
> > >   1 file changed, 66 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi 
> > > b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > > index 8bfc2db44624..0eef77e36609 100644
> > > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > > @@ -150,6 +150,46 @@ qfprom: efuse@a4000 {
> > >               reg = <0x000a4000 0x721>;
> > >               #address-cells = <1>;
> > >               #size-cells = <1>;
> > > +
> > > +            tsens_mode: mode@3e1 {
> > > +                reg = <0x3e1 0x1>;
> > > +                bits = <0 3>;
> > > +            };
> > > +
> > > +            tsens_base0: base0@3e1 {
> > > +                reg = <0x3e1 0x2>;
> > > +                bits = <3 10>;
> > > +            };
> > > +
> > > +            tsens_base1: base1@3e2 {
> > > +                reg = <0x3e2 0x2>;
> > > +                bits = <5 10>;
> > > +            };

Please order device nodes according to the address. So mode/base should 
come after sensors data.

> > > +
> > > +            s11: s11@3a5 {
> > > +                reg = <0x3a5 0x1>;
> > > +                bits = <4 4>;
> > > +            };
> > > +
> > > +            s12: s12@3a6 {
> > > +                reg = <0x3a6 0x1>;
> > > +                bits = <0 4>;
> > > +            };
> > > +
> > > +            s13: s13@3a6 {
> > > +                reg = <0x3a6 0x1>;
> > > +                bits = <4 4>;
> > > +            };
> > > +
> > > +            s14: s14@3ad {
> > > +                reg = <0x3ad 0x2>;
> > > +                bits = <7 4>;
> > > +            };
> > > +
> > > +            s15: s15@3ae {
> > > +                reg = <0x3ae 0x1>;
> > > +                bits = <3 4>;
> > > +            };
> > >           };
> > >             rng: rng@e3000 {
> > > @@ -159,6 +199,32 @@ rng: rng@e3000 {
> > >               clock-names = "core";
> > >           };
> > >   +        tsens: thermal-sensor@4a9000 {
> > > +            compatible = "qcom,ipq5332-tsens";
> > > +            reg = <0x4a9000 0x1000>,
> > > +                  <0x4a8000 0x1000>;
> > > +            nvmem-cells = <&tsens_mode>,
> > > +                      <&tsens_base0>,
> > > +                      <&tsens_base1>,
> > > +                      <&s11>,
> > > +                      <&s12>,
> > > +                      <&s13>,
> > > +                      <&s14>,
> > > +                      <&s15>;
> > > +            nvmem-cell-names = "mode",
> > > +                       "base0",
> > > +                       "base1",
> > > +                       "s11",
> > > +                       "s12",
> > > +                       "s13",
> > > +                       "s14",
> > > +                       "s15";
> >
> > Previously you had data for other sensors here. Are they not used at 
> > all, not wired, have no known-good placement? I think it might be 
> > better to declare all sensors here (and in the driver too) and then 
> > consider enabling only a pile of them in the thermal-zone node.
>
> Remaining sensors are not used at all. It is not wired. Only above 
> sensors are placed in SoC.

Ack, thanks for the explanation. Then this is good.

> - Praveenkumar
>
> > > +            interrupts = <GIC_SPI 320 IRQ_TYPE_LEVEL_HIGH>;
> > > +            interrupt-names = "combined";
> > > +            #qcom,sensors = <5>;
> > > +            #thermal-sensor-cells = <1>;
> > > +        };
> > > +
> > >           tlmm: pinctrl@1000000 {
> > >               compatible = "qcom,ipq5332-tlmm";
> > >               reg = <0x01000000 0x300000>;

--
With best wishes
Dmitry