Re: [PATCH v2 2/2] KVM: s390: pv: fix index value of replaced ASCE

From: Philippe Mathieu-Daudé
Date: Tue Jul 11 2023 - 10:13:17 EST


On 5/7/23 13:19, Claudio Imbrenda wrote:
The index field of the struct page corresponding to a guest ASCE should
be 0. When replacing the ASCE in s390_replace_asce(), the index of the
new ASCE should also be set to 0.

Having the wrong index might lead to the wrong addresses being passed
around when notifying pte invalidations, and eventually to validity
intercepts (VM crash) if the prefix gets unmapped and the notifier gets
called with the wrong address.

Can that also happen in crst_table_alloc()?

Signed-off-by: Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx>
---
arch/s390/mm/gmap.c | 1 +
1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>