Re: [cocci] [PATCH] Revert "debugfs, coccinelle: check for obsolete DEFINE_SIMPLE_ATTRIBUTE() usage"

From: Sean Christopherson
Date: Tue Jul 11 2023 - 10:13:13 EST


On Tue, Jul 11, 2023, Markus Elfring wrote:
> > Remove coccinelle's recommendation to use DEFINE_SIMPLE_ATTRIBUTE()
> > instead of DEFINE_SIMPLE_ATTRIBUTE().
>
> I find this wording inappropriate for a change request
> because of an undesirable term duplication.
> Would you like to refer to the identifier “DEFINE_DEBUGFS_ATTRIBUTE” here?

Doh, copy+paste fail on my part.

> > Regardless of whether or not the
> > "significant overhead" incurred by debugfs_create_file() is actually
> > meaningful, warnings from the script have led to a rash of low-quality
> > patches that have sowed confusion and consumed maintainer time for little
> > to no benefit. There have been no less than four attempts to "fix" KVM,
> > and a quick search on lore shows that KVM is not alone.
>
> Will such information trigger any further clarification?

I don't quite follow the question. What information, and what clarification?