Re: [PATCH 09/18] soc: renesas: Move power-domain drivers to the genpd dir

[Ulf Hansson]

On Mon, 10 Jul 2023 at 14:53, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Ulf,
>
> On Fri, Jul 7, 2023 at 4:04 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> > Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Cc: Magnus Damm <magnus.damm@xxxxxxxxx>
> > Cc: <linux-renesas-soc@xxxxxxxxxxxxxxx>
> > Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>
> Thanks for your patch!
>
> > ---
> >  MAINTAINERS                                   |  1 +
> >  drivers/genpd/Makefile                        |  1 +
> >  drivers/genpd/renesas/Makefile                | 30 +++++++++++++++++++
> >  drivers/{soc => genpd}/renesas/r8a7742-sysc.c |  0
> >  drivers/{soc => genpd}/renesas/r8a7743-sysc.c |  0
> >  drivers/{soc => genpd}/renesas/r8a7745-sysc.c |  0
> >  .../{soc => genpd}/renesas/r8a77470-sysc.c    |  0
> >  .../{soc => genpd}/renesas/r8a774a1-sysc.c    |  0
> >  .../{soc => genpd}/renesas/r8a774b1-sysc.c    |  0
> >  .../{soc => genpd}/renesas/r8a774c0-sysc.c    |  0
> >  .../{soc => genpd}/renesas/r8a774e1-sysc.c    |  0
> >  drivers/{soc => genpd}/renesas/r8a7779-sysc.c |  0
> >  drivers/{soc => genpd}/renesas/r8a7790-sysc.c |  0
> >  drivers/{soc => genpd}/renesas/r8a7791-sysc.c |  0
> >  drivers/{soc => genpd}/renesas/r8a7792-sysc.c |  0
> >  drivers/{soc => genpd}/renesas/r8a7794-sysc.c |  0
> >  drivers/{soc => genpd}/renesas/r8a7795-sysc.c |  0
> >  drivers/{soc => genpd}/renesas/r8a7796-sysc.c |  0
> >  .../{soc => genpd}/renesas/r8a77965-sysc.c    |  0
> >  .../{soc => genpd}/renesas/r8a77970-sysc.c    |  0
> >  .../{soc => genpd}/renesas/r8a77980-sysc.c    |  0
> >  .../{soc => genpd}/renesas/r8a77990-sysc.c    |  0
> >  .../{soc => genpd}/renesas/r8a77995-sysc.c    |  0
> >  .../{soc => genpd}/renesas/r8a779a0-sysc.c    |  0
> >  .../{soc => genpd}/renesas/r8a779f0-sysc.c    |  0
> >  .../{soc => genpd}/renesas/r8a779g0-sysc.c    |  0
> >  .../{soc => genpd}/renesas/rcar-gen4-sysc.c   |  0
> >  .../{soc => genpd}/renesas/rcar-gen4-sysc.h   |  0
> >  drivers/{soc => genpd}/renesas/rcar-sysc.c    |  0
> >  drivers/{soc => genpd}/renesas/rcar-sysc.h    |  0
> >  drivers/{soc => genpd}/renesas/rmobile-sysc.c |  0
> >  drivers/soc/renesas/Makefile                  | 27 -----------------
> >  32 files changed, 32 insertions(+), 27 deletions(-)
>
> LGTM.

Thanks! I defer to your formal ack, before adding your tag.

>
> Is there any specific reason why you're not moving the SYSC_* symbols
> from drivers/soc/renesas/Kconfig to drivers/genpd/renesas/Kconfig?

I was looking into moving the corresponding Kconfig options for all
SoCs/platforms, but I found it being a bit controversial at this
point. One could argue that it looks easier to understand the Kconfig
files, by keeping the SoC specific options together as there are
simply always some kind of dependency that needs to be described too.

Moreover, we currently don't have a menu option for the
CONFIG_GENERIC_PM_DOMAINS. I guess that could be discussed too,
especially if we should want to move the Kconfig files to the genpd
directory.

That said, for now, I suggest we keep the Kconfig files in the soc
directory. Or at least address this separately on top of the $subject
series.

Kind regards
Uffe