Re: [PATCH 09/18] soc: renesas: Move power-domain drivers to the genpd dir

[Geert Uytterhoeven]

Hi Ulf,

On Fri, Jul 7, 2023 at 4:04 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Cc: Magnus Damm <magnus.damm@xxxxxxxxx>
> Cc: <linux-renesas-soc@xxxxxxxxxxxxxxx>
> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

Thanks for your patch!

> ---
>  MAINTAINERS                                   |  1 +
>  drivers/genpd/Makefile                        |  1 +
>  drivers/genpd/renesas/Makefile                | 30 +++++++++++++++++++
>  drivers/{soc => genpd}/renesas/r8a7742-sysc.c |  0
>  drivers/{soc => genpd}/renesas/r8a7743-sysc.c |  0
>  drivers/{soc => genpd}/renesas/r8a7745-sysc.c |  0
>  .../{soc => genpd}/renesas/r8a77470-sysc.c    |  0
>  .../{soc => genpd}/renesas/r8a774a1-sysc.c    |  0
>  .../{soc => genpd}/renesas/r8a774b1-sysc.c    |  0
>  .../{soc => genpd}/renesas/r8a774c0-sysc.c    |  0
>  .../{soc => genpd}/renesas/r8a774e1-sysc.c    |  0
>  drivers/{soc => genpd}/renesas/r8a7779-sysc.c |  0
>  drivers/{soc => genpd}/renesas/r8a7790-sysc.c |  0
>  drivers/{soc => genpd}/renesas/r8a7791-sysc.c |  0
>  drivers/{soc => genpd}/renesas/r8a7792-sysc.c |  0
>  drivers/{soc => genpd}/renesas/r8a7794-sysc.c |  0
>  drivers/{soc => genpd}/renesas/r8a7795-sysc.c |  0
>  drivers/{soc => genpd}/renesas/r8a7796-sysc.c |  0
>  .../{soc => genpd}/renesas/r8a77965-sysc.c    |  0
>  .../{soc => genpd}/renesas/r8a77970-sysc.c    |  0
>  .../{soc => genpd}/renesas/r8a77980-sysc.c    |  0
>  .../{soc => genpd}/renesas/r8a77990-sysc.c    |  0
>  .../{soc => genpd}/renesas/r8a77995-sysc.c    |  0
>  .../{soc => genpd}/renesas/r8a779a0-sysc.c    |  0
>  .../{soc => genpd}/renesas/r8a779f0-sysc.c    |  0
>  .../{soc => genpd}/renesas/r8a779g0-sysc.c    |  0
>  .../{soc => genpd}/renesas/rcar-gen4-sysc.c   |  0
>  .../{soc => genpd}/renesas/rcar-gen4-sysc.h   |  0
>  drivers/{soc => genpd}/renesas/rcar-sysc.c    |  0
>  drivers/{soc => genpd}/renesas/rcar-sysc.h    |  0
>  drivers/{soc => genpd}/renesas/rmobile-sysc.c |  0
>  drivers/soc/renesas/Makefile                  | 27 -----------------
>  32 files changed, 32 insertions(+), 27 deletions(-)

LGTM.

Is there any specific reason why you're not moving the SYSC_* symbols
from drivers/soc/renesas/Kconfig to drivers/genpd/renesas/Kconfig?
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds