Re: staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()

From: Zhang Shurong
Date: Mon Jul 10 2023 - 01:48:01 EST


Hi Markus,

> 2023年7月10日 03:56,Markus Elfring <Markus.Elfring@xxxxxx> 写道:
>
>>>> The "exc->key_len" is a u16 that comes from the user. If it's over
>>>> IW_ENCODING_TOKEN_MAX (64) that could lead to memory corruption.
>>>
>>> Please choose an imperative change suggestion.
>>
>> Please stop reviewing staging patches, it is not helpful for anyone.
>
> It seems that further contributors need to become more aware about
> (and finally adhere to) requirements from the Linux development documentation.
>
> Regards,
> Markus

I'm guilty of my incorrect patch format. And do I need to write another
patch to fix this format issue?

Best regards
Shurong