Re: staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()

From: Greg Kroah-Hartman
Date: Mon Jul 10 2023 - 01:47:13 EST


On Mon, Jul 10, 2023 at 01:41:07PM +0800, Zhang Shurong wrote:
> Hi Markus,
>
> > 2023年7月10日 03:56,Markus Elfring <Markus.Elfring@xxxxxx> 写道:
> >
> >>>> The "exc->key_len" is a u16 that comes from the user. If it's over
> >>>> IW_ENCODING_TOKEN_MAX (64) that could lead to memory corruption.
> >>>
> >>> Please choose an imperative change suggestion.
> >>
> >> Please stop reviewing staging patches, it is not helpful for anyone.
> >
> > It seems that further contributors need to become more aware about
> > (and finally adhere to) requirements from the Linux development documentation.
> >
> > Regards,
> > Markus
>
> I'm guilty of my incorrect patch format. And do I need to write another
> patch to fix this format issue?

One of the hardest things in kernel development is learning what
reviews, and what reviewers, should be ignored. This is one of them :)

No need to change the patch yet, let me get to this change this week and
I'll let you know.

thanks,

greg k-h