Re: [PATCH 04/11] iio: adc: Update bindings to remove support for ADC7 name used on QCOM PMICs
From: Krzysztof Kozlowski
Date: Sun Jul 09 2023 - 13:19:35 EST
On 08/07/2023 09:28, Jishnu Prakash wrote:
> Now that usage of "ADC7" name has been replaced with usage of "ADC5
> Gen2" name everywhere, remove all support for "ADC7" name.
Why?
>
> Signed-off-by: Jishnu Prakash <quic_jprakash@xxxxxxxxxxx>
> ---
> .../bindings/iio/adc/qcom,spmi-vadc.yaml | 5 +-
> .../bindings/thermal/qcom-spmi-adc-tm5.yaml | 1 -
> .../dt-bindings/iio/qcom,spmi-adc7-pm8350.h | 63 -------------
> .../dt-bindings/iio/qcom,spmi-adc7-pm8350b.h | 88 -------------------
> .../dt-bindings/iio/qcom,spmi-adc7-pmk8350.h | 46 ----------
> .../dt-bindings/iio/qcom,spmi-adc7-pmr735a.h | 28 ------
> .../dt-bindings/iio/qcom,spmi-adc7-pmr735b.h | 28 ------
> include/dt-bindings/iio/qcom,spmi-vadc.h | 76 ----------------
> 8 files changed, 1 insertion(+), 334 deletions(-)
> delete mode 100644 include/dt-bindings/iio/qcom,spmi-adc7-pm8350.h
> delete mode 100644 include/dt-bindings/iio/qcom,spmi-adc7-pm8350b.h
> delete mode 100644 include/dt-bindings/iio/qcom,spmi-adc7-pmk8350.h
> delete mode 100644 include/dt-bindings/iio/qcom,spmi-adc7-pmr735a.h
> delete mode 100644 include/dt-bindings/iio/qcom,spmi-adc7-pmr735b.h
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
> index f886977de165..eb7d16e385ad 100644
> --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
> @@ -26,7 +26,6 @@ properties:
> - qcom,spmi-vadc
> - qcom,spmi-adc5
> - qcom,spmi-adc-rev2
> - - qcom,spmi-adc7
NAK. You did not explained why dropping existing compatible is correct,
expected and okay.
Also:
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
Best regards,
Krzysztof