Re: [Intel-wired-lan] [PATCH net v2] ice: Unregister netdev and devlink_port only once

From: Tony Nguyen
Date: Fri Jul 07 2023 - 13:04:36 EST


On 7/6/2023 2:30 PM, Petr Oros wrote:
Petr Oros píše v Po 19. 06. 2023 v 12:58 +0200:
Since commit 6624e780a577fc ("ice: split ice_vsi_setup into smaller
functions") ice_vsi_release does things twice. There is unregister
netdev which is unregistered in ice_deinit_eth also.

It also unregisters the devlink_port twice which is also unregistered
in ice_deinit_eth(). This double deregistration is hidden because
devl_port_unregister ignores the return value of xa_erase.

Hi,

Is it possible to push this patch forward? I think the questions have
been answered. Or is something still unclear?

I was expecting a new version based on the question/request [1] (so set to changes requested) before the response. Will apply and have it move forward.

Thanks,
Tony

[1] https://lore.kernel.org/intel-wired-lan/eda7b84e56123bce167a64133572440e6806ef1e.camel@xxxxxxxxxx/T/#mbef0a70424d01bb8fcc1ae1a4865c617fbb4befc