Re: [PATCH] gpiolib: add missing include

[Kent Gibson]

On Wed, Jul 05, 2023 at 12:59:19PM +0200, Bartosz Golaszewski wrote:
> On Wed, Jul 5, 2023 at 12:57 PM Kent Gibson <warthog618@xxxxxxxxx> wrote:
> >
> > On Wed, Jul 05, 2023 at 09:42:19AM +0200, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> > >
> > > gpiolib.h uses notifiers but doesn't include <linux/notifier.h>.
> > >
> >
> > Fair enough.
> >
> > Reviewed-by: Kent Gibson <warthog618@xxxxxxxxx>
> >
> > Same is true for gpiolib-cdev, btw.
> > You want to touch that one up as well?
> >
> 
> No, it already includes gpiolib.h.
> 

Yeah, but that is indirect, and gpiolib-cdev.c uses struct notifier_block
directly.  Doesn't that warrant an explicit include?

Cheers,
Kent.