Re: [PATCH] gpiolib: add missing include

From: Bartosz Golaszewski
Date: Wed Jul 05 2023 - 06:59:36 EST


On Wed, Jul 5, 2023 at 12:57 PM Kent Gibson <warthog618@xxxxxxxxx> wrote:
>
> On Wed, Jul 05, 2023 at 09:42:19AM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >
> > gpiolib.h uses notifiers but doesn't include <linux/notifier.h>.
> >
>
> Fair enough.
>
> Reviewed-by: Kent Gibson <warthog618@xxxxxxxxx>
>
> Same is true for gpiolib-cdev, btw.
> You want to touch that one up as well?
>

No, it already includes gpiolib.h.

Bart

> Cheers,
> Kent.
>
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> > ---
> > drivers/gpio/gpiolib.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpio/gpiolib.h b/drivers/gpio/gpiolib.h
> > index cca81375f127..1409d52487c0 100644
> > --- a/drivers/gpio/gpiolib.h
> > +++ b/drivers/gpio/gpiolib.h
> > @@ -14,6 +14,7 @@
> > #include <linux/err.h>
> > #include <linux/device.h>
> > #include <linux/module.h>
> > +#include <linux/notifier.h>
> > #include <linux/cdev.h>
> > #include <linux/rwsem.h>
> >
> > --
> > 2.39.2
> >