Re: [PATCH 00/12] Convert write_cache_pages() to an iterator

From: Matthew Wilcox
Date: Tue Jul 04 2023 - 14:08:23 EST


On Wed, Jun 28, 2023 at 09:03:10PM +0100, David Howells wrote:
> Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> > I'm looking at afs writeback now.
>
> :-)
>
> > fs/iomap/buffered-io.c | 14 +-
> > include/linux/pagevec.h | 18 +++
> > include/linux/writeback.h | 22 ++-
> > mm/page-writeback.c | 310 +++++++++++++++++++++-----------------
> > 4 files changed, 216 insertions(+), 148 deletions(-)
>
> Documentation/mm/writeback.rst too please.

$ ls Documentation/mm/w*
ls: cannot access 'Documentation/mm/w*': No such file or directory

$ git grep writeback Documentation/mm
Documentation/mm/multigen_lru.rst:do not require TLB flushes; clean pages do not require writeback.
Documentation/mm/page_migration.rst:2. Ensure that writeback is complete.
Documentation/mm/page_migration.rst:15. Queued up writeback on the new page is triggered.
Documentation/mm/physical_memory.rst:``nr_writeback_throttled``
Documentation/mm/physical_memory.rst: Number of pages written while reclaim is throttled waiting for writeback.

Or are you suggesting I write a new piece of kernel documentation?
If so, I respectfully decline. I've updated the kernel-doc included
in Documentation/core-api/mm-api.rst and I think that's all I can
reasonably be asked to do.