Re: [PATCH] perf vendor events arm64: Add AmpereOne core pmu events

From: John Garry
Date: Thu Jun 22 2023 - 06:11:52 EST


On 22/06/2023 04:27, Ilkka Koskinen wrote:

+        "ArchStdEvent": "L1D_CACHE_LMISS_RD"
+    },
+    {
+        "ArchStdEvent": "L1D_CACHE_LMISS"

L1D_CACHE_LMISS is not defined anywhere.


Good catch! I must have thought the python script would at least print a warning of missing event as I compared the build logs with and without the patch. I can prepare a fix for this and submit with another couple of patches. I'm hoping to be able to do that by the beginning of next week.

Hi Ilkka,

Previously the generation of pmu-events.c would fail for a failed event fixup, like what we have here. So were you going to re-introduce this feature to fail the generation of pmu-events.c for this? It was not clear to me which patches you were going to prepare.

Thanks,
John