Re: [PATCH] perf vendor events arm64: Add AmpereOne core pmu events

[Ilkka Koskinen]

Hi Dave,

On Wed, 21 Jun 2023, Dave Kleikamp wrote:
> On 4/27/23 5:32PM, Ilkka Koskinen wrote:
> > Add JSON files for AmpereOne core PMU events.
> >
> > Signed-off-by: Doug Rady <dcrady@xxxxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Ilkka Koskinen <ilkka@xxxxxxxxxxxxxxxxxxxxxx>
> > ---
>
>  CLIP
>
> > diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json 
> > b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json
> > new file mode 100644
> > index 000000000000..fc0633054211
> > --- /dev/null
> > +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json
> > @@ -0,0 +1,104 @@
> > +[
> > +    {
> > +        "ArchStdEvent": "L1D_CACHE_RD"
> > +    },

....

> > +    {
> > +        "ArchStdEvent": "L1D_CACHE_LMISS_RD"
> > +    },
> > +    {
> > +        "ArchStdEvent": "L1D_CACHE_LMISS"
>
> L1D_CACHE_LMISS is not defined anywhere.


Good catch! I must have thought the python script would at least print a 
warning of missing event as I compared the build logs with and without the 
patch. I can prepare a fix for this and submit with another couple of 
patches. I'm hoping to be able to do that by the beginning of next week.

Cheers, Ilkka

> > +    },
> > +    {
> > +        "ArchStdEvent": "L1I_CACHE_LMISS"
> > +    },
> > +    {
> > +        "ArchStdEvent": "L2D_CACHE_LMISS_RD"
> > +    }
> > +]