RE: [PATCH v8 05/33] x86/traps: add external_interrupt() to dispatch external interrupts

[Thomas Gleixner]

On Mon, Jun 19 2023 at 19:16, Li, Xin3 wrote:
>> > Add external_interrupt() to dispatch external interrupts to their handlers.
>> >
>> > If an external interrupt is a system interrupt, dipatch it through
>> > system_interrupt_handlers table, otherwise to
>> > dispatch_common_interrupt().
>> 
>> This naming convention sucks. external interrupts which can be system
>> interrupts. Come on.
>
> This name dispatch_common_interrupt() comes from arch/x86/kernel/irq.c:

That's not the point. Your changelog says:

  If an external interrupt is a system interrupt...

It's either an external interrupt which goes through common_interrupt()
or it is a system interrupt which goes through it's very own handler,
no?

Thanks,

        tglx