Re: [PATCH 2/3] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board

From: Krzysztof Kozlowski
Date: Fri Jun 16 2023 - 07:36:44 EST


On 16/06/2023 13:06, Josua Mayer wrote:
> Add DT compatible for SolidRun LX2162A SoM and Clearfog board.
>
> Signed-off-by: Josua Mayer <josua@xxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 15d411084065..438a4ece8157 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1373,9 +1373,11 @@ properties:
> - description: SolidRun LX2160A based Boards
> items:
> - enum:
> + - solidrun,clearfog
> - solidrun,clearfog-cx
> - solidrun,honeycomb
> - const: solidrun,lx2160a-cex7
> + - const: solidrun,lx2162a-som
> - const: fsl,lx2160a

You change existing entries, breaking boards and changing the meaning,
without any explanation in commit msg. That's not how it is done. Please
provide rationale in commit msg.

Best regards,
Krzysztof