Re: [PATCH v6 18/22] clk: qcom: smd-rpm: Separate out interconnect bus clocks

[Stephen Boyd]

Quoting Konrad Dybcio (2023-06-14 11:04:37)
> The interconnect bus clocks are now handled within the ICC framework.
> They still however need to get a kickstart *before* we call
> clk_smd_rpm_enable_scaling(), or RPM will assume that they should all
> be running at 0 kHz and the system will inevitably die.
> 
> Separate them out to ensure such a kickstart can still take place.
> 
> As a happy accident, the file got smaller:
> 
> Total: Before=41951, After=41555, chg -0.94%
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
>  drivers/clk/qcom/clk-smd-rpm.c | 278 +++++++++++++++++------------------------
>  1 file changed, 115 insertions(+), 163 deletions(-)
> 
> diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c
> index 6e7f0438e8b8..0d1d97659d59 100644
> --- a/drivers/clk/qcom/clk-smd-rpm.c
> +++ b/drivers/clk/qcom/clk-smd-rpm.c
> @@ -498,13 +506,69 @@ DEFINE_CLK_SMD_RPM_XO_BUFFER(div_clk1, 11, 19200000);
>  DEFINE_CLK_SMD_RPM_XO_BUFFER(div_clk2, 12, 19200000);
>  DEFINE_CLK_SMD_RPM_XO_BUFFER(div_clk3, 13, 19200000);
>  
> +static struct clk_smd_rpm *bimc_pcnoc_icc_clks[] = {

Can these be const arrays?

> +       &clk_smd_rpm_bimc_clk,
> +       &clk_smd_rpm_bus_0_pcnoc_clk,
> +};
> +
[...]
> @@ -1332,6 +1275,15 @@ static int rpm_smd_clk_probe(struct platform_device *pdev)
>                         goto err;
>         }
>  
> +       for (i = 0; i < desc->num_icc_clks; i++) {
> +               if (!desc->icc_clks[i])
> +                       continue;
> +
> +               ret = clk_smd_rpm_handoff(desc->icc_clks[i]);

This API can probably take a const struct clk_smd_rpm pointer as well.